Re: [PATCH v2 2/3] dt-bindings: media: i2c: Document 'remote-endpoint'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sergei,

On Wed, Jul 15, 2020 at 11:10:15AM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 14.07.2020 17:28, Jacopo Mondi wrote:
>
> > Document the 'remote-endpoint' property and add it to the list of required
> > endpoint properties in imx219 and ov8856 dt-schema binding files.
> >
> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > Signed-off-by: Jacopo Mondi <jacopo@xxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/media/i2c/imx219.yaml | 5 +++++
> >   Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 5 +++++
> >   2 files changed, 10 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/imx219.yaml b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> > index dfc4d29a4f04..0251e15fe0a7 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/imx219.yaml
> > @@ -71,8 +71,13 @@ properties:
> >               description:
> >                 Allowed data bus frequencies.
> > +          remote-endpoint:
> > +            description: |-
> > +              phandle to the video receiver input port
>
>    s/to/of/?
>
> > +
> >           required:
> >             - link-frequencies
> > +          - remote-endpoint
> >   required:
> >     - compatible
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > index 1956b2a32bf4..c1f363bb5aee 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > @@ -84,9 +84,14 @@ properties:
> >                 Allowed data bus frequencies. 360000000, 180000000 Hz or both
> >                 are supported by the driver.
> > +          remote-endpoint:
> > +            description: |-
> > +              phandle to the video receiver input port
>
>    s/to/of/?

I see both being used in the existing Documentation.
In the media/ folder it seems like "phandle to" is the only used
version, so I think I will go with that for consistency, unless this
is grammatically wrong and I didn't realize it :)

>
> [...]
>
> MBR, Sergei



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux