Hi Dillon,
On Tue, 14 Jul 2020 11:43:31 +0800 dillon min <dillon.minfei@xxxxxxxxx> wrote:
>
> On Tue, Jul 14, 2020 at 11:38 AM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, 14 Jul 2020 11:23:18 +0800 dillon.minfei@xxxxxxxxx wrote:
> > >
> > > From: dillon min <dillon.minfei@xxxxxxxxx>
> > >
> > > Fixes: 1a5cd7c23cc5 ("bus: ti-sysc: Enable all clocks directly during init to read revision")
> > >
> > > [1]: https://www.ti.com/lit/pdf/spruh73 Chapter-23, Figure 23-1. DCAN
> > > Integration
> > > [2]: https://www.ti.com/lit/pdf/spruhl7 Chapter-25, Figure 25-1. DCAN
> > > Integration
> > > [3]: commit 516f1117d0fb ("ARM: dts: Configure osc clock for d_can on am335x")
> > >
> > > Signed-off-by: dillon min <dillon.minfei@xxxxxxxxx>
> > > ---
> > >
> > > Hi Stephen,
> > >
> > > This changes correct commit messages based on your reviewing.
> > > make Fixes tags to oneline.
> > > make all commit message tags at the end of commit message
> >
> > But the Fixes: line should be down with the Signed-off-by: line ...
> >
> Ok, should it be like this，i will resubmit it.
>
> Subject: [PATCH v2] Since am437x have the same clock structure with am335x
> [1][2], reuse the code from Tony Lindgren's patch [3] to fix dcan
> probe failed on the am437x platform.
You should have a shorter subject and maybe the above could be the
first paragraph of the commit message.
>
> [1]: https://www.ti.com/lit/pdf/spruh73 Chapter-23, Figure 23-1. DCAN
> Integration
> [2]: https://www.ti.com/lit/pdf/spruhl7 Chapter-25, Figure 25-1. DCAN
> Integration
> [3]: commit 516f1117d0fb ("ARM: dts: Configure osc clock for d_can on am335x")
>
> Signed-off-by: dillon min <dillon.minfei@xxxxxxxxx>
> Fixes: 1a5cd7c23cc5 ("bus: ti-sysc: Enable all clocks directly during
> init to read revision")
No wrapping the the Fixes line, please and it would usually go before
your Signed=off-by line
--
Cheers,
Stephen Rothwell
Attachment:
pgpEQKaLOsV1J.pgp
Description: OpenPGP digital signature
