On Sat, Jun 13, 2020 at 12:26:56PM +0200, Daniel González Cabanelas wrote: > Add Linkstation poweroff bindings documentation. > > Signed-off-by: Daniel González Cabanelas <dgcbueu@xxxxxxxxx> > --- > Changes in v3: > - "phy-handle,intn" property deleted. Now autodetection used. > - Cosmetic changes > Changes in v2: > - Changed the required properties and description to adjust to the new > driver now enabling the WoL feature on the device. > > .../power/reset/linkstation-poweroff.yaml | 35 +++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/reset/linkstation-poweroff.yaml > > diff --git a/Documentation/devicetree/bindings/power/reset/linkstation-poweroff.yaml b/Documentation/devicetree/bindings/power/reset/linkstation-poweroff.yaml > new file mode 100644 > index 0000000000..8845333ca4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/reset/linkstation-poweroff.yaml > @@ -0,0 +1,35 @@ > +# SPDX-License-Identifier: (GPL-2.0+ OR BSD-2-Clause) As I said before: GPL-2.0-only > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/power/reset/linkstation-poweroff.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Buffalo Linkstation poweroff Binding > + > +maintainers: > + - Daniel González Cabanelas <dgcbueu@xxxxxxxxx> > + > +description: | > + Some Buffalo LinkStations (ARM MVEBU boards) use an output pin at the ethernet > + PHY (LED2/INTn) to inform the board if the power off operation must be performed > + at restart time. This pin is ORed with the power switch and allows the WOL > + function to be also used. > + > + When the power-off handler is called, the ethernet PHY INTn ouptut is set to > + LOW state. If the restart command is executed then the PHY INTn output is > + forced to HIGH state. > + > +properties: > + compatible: > + const: linkstation,power-off > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + poweroff { > + compatible = "linkstation,power-off"; > + }; This is not what I was suggesting in the last version. You don't need a binding for this. Use the root node compatible string. Your driver initcall needs to check the root compatible and create a platform device if it matches. Rob
