On Sat, Jul 4, 2020 at 3:26 PM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > > On Sat, Jul 04, 2020 at 11:03:21PM +0200, Geert Uytterhoeven wrote: > > Hi Sam, > > > > Thanks for your patch! > > > > On Sat, Jul 4, 2020 at 4:37 PM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote: > > > Now that dt-extract-example gained support for using root nodes > > > in examples, update the example for the simple-frambuffer binding to use it. > > > > simple-framebuffer > Thanks, will fix. > > > > > > This gives us a better example and kill a long standing warning: > > > > > > simple-framebuffer.example.dts:23.16-39.11: > > > Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node > > > > > > Note: To get the update dt-extract-example execute: > > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > > > > > Signed-off-by: Sam Ravnborg <sam@xxxxxxxxxxxx> > > > > > --- a/Documentation/devicetree/bindings/display/simple-framebuffer.yaml > > > +++ b/Documentation/devicetree/bindings/display/simple-framebuffer.yaml > > > @@ -152,28 +152,29 @@ additionalProperties: false > > > > > > examples: > > > - | > > > - aliases { > > > - display0 = &lcdc0; > > > > Why drop the aliases example? > I did not see it had any value for the binding that the example shall > demonstrate. But it was not somthing I have given much thought of. I don't think anything actually supports 'display' aliases and it is beyond the scope of this binding, so I'd drop. stdout-path should be dropped too as it points to this. Rob
