> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: Tuesday, July 7, 2020 9:08 PM
> To: G Jaya Kumaran, Vineetha <vineetha.g.jaya.kumaran@xxxxxxxxx>
> Cc: davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; mcoquelin.stm32@xxxxxxxxx;
> robh+dt@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> Voon, Weifeng <weifeng.voon@xxxxxxxxx>; Kweh, Hock Leong
> <hock.leong.kweh@xxxxxxxxx>; Ong, Boon Leong <boon.leong.ong@xxxxxxxxx>
> Subject: Re: [PATCH 1/2] dt-bindings: net: Add bindings for Intel Keem Bay
>
> > + mdio0 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + compatible = "snps,dwmac-mdio";
> > +
> > + ethernet-phy@0 {
> > + compatible = "ethernet-phy-id0141.0dd0",
> > + "ethernet-phy-ieee802.3-c22";
>
> You only need to provide the phy-id when the PHY is broken and registers 2 and
> 3 don't contain a valid ID. And c22 is the default, so also not needed. The
> Marvell 88E1510 will work without these compatible strings.
>
> Andrew
Thanks Andrew, I will change this in v2.
