Re: [PATCH v12 0/2] PCI: microchip: Add host driver for Microchip PCIe controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 02, 2020 at 03:37:12PM +0000, Daire.McNamara@xxxxxxxxxxxxx wrote:
> This v12 patch adds support for the Microchip PCIe PolarFire PCIe
> controller when configured in host (Root Complex) mode.

> Daire McNamara (2):
>   PCI: microchip: Add host driver for Microchip PCIe controller
>   PCI: microchip: Add host driver for Microchip PCIe controller

Hi Daire,

I see this in the lore archive:
https://lore.kernel.org/linux-pci/97e528fd7582186d7db4073c78d72601b2ce553f.camel@xxxxxxxxxxxxx/

but

  - It's not threaded correctly.  The 1/2 and 2/2 patches should be
    responses to the 0/2 cover letter.  The fact that they're not
    means one cannot navigate through the series on
    https://lore.kernel.org.

  - For some reason none of these made it to me directly even though
    I'm in the To: list as well as subscribed to the linux-pci list.
    They *do* appear in both patchwork and lore, and I think they both
    get things via the linux-pci list, so I don't know what's wrong.

    I did correct Rob's email address; maybe that was part of it?

  - The patches should have different subjects.  The DT binding should
    have a subject that matches the history in
    Documentation/devicetree/bindings/pci/, e.g., something like:

    dt-bindings: PCI: microchip: Add Microchip PolarFire host binding

  - The commit logs should be good English; for example, they should
    start with a capital letter.

>  .../bindings/pci/microchip,pcie-host.yaml     |  93 +++
>  drivers/pci/controller/Kconfig                |   9 +
>  drivers/pci/controller/Makefile               |   1 +
>  drivers/pci/controller/pcie-microchip-host.c  | 683 ++++++++++++++++++
>  4 files changed, 786 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
>  create mode 100644 drivers/pci/controller/pcie-microchip-host.c
> 
> 
> base-commit: cd77006e01b3198c75fb7819b3d0ff89709539bb
> -- 
> 2.17.1
> 



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux