Hi, On Sun, Jun 21, 2020 at 02:11:06AM +0200, Alexandre Belloni wrote: > On 21/06/2020 00:42:19+0200, Jonathan Neuschäfer wrote: > > With this driver, mainline Linux can keep its time and date in sync with > > the vendor kernel. > > > > Advanced functionality like alarm and automatic power-on is not yet > > supported. > > > > Please report the results of rtctest (from the kernel tree) [...] # ./rtctest [==========] Running 7 tests from 2 test cases. [ RUN ] rtc.date_read ../../tools/testing/selftests/rtc/rtctest.c:49:date_read:Current RTC date/time is 11/04/2006 23:11:23. [ OK ] rtc.date_read [ RUN ] rtc.uie_read [ 180.651355] random: crng init done uie_read: Test terminated by timeout [ FAIL ] rtc.uie_read [ RUN ] rtc.uie_select ../../tools/testing/selftests/rtc/rtctest.c:98:uie_select:Expected 0 (0) != rc (0) uie_select: Test terminated by assertion [ FAIL ] rtc.uie_select [ RUN ] rtc.alarm_alm_set ../../tools/testing/selftests/rtc/rtctest.c:129:alarm_alm_set:skip alarms are not supported. [ OK ] rtc.alarm_alm_set [ RUN ] rtc.alarm_wkalm_set ../../tools/testing/selftests/rtc/rtctest.c:185:alarm_wkalm_set:skip alarms are not supported. [ OK ] rtc.alarm_wkalm_set [ RUN ] rtc.alarm_alm_set_minute ../../tools/testing/selftests/rtc/rtctest.c:231:alarm_alm_set_minute:skip alarms are not supported. [ OK ] rtc.alarm_alm_set_minute [ RUN ] rtc.alarm_wkalm_set_minute ../../tools/testing/selftests/rtc/rtctest.c:287:alarm_wkalm_set_minute:skip alarms are not supported. [ OK ] rtc.alarm_wkalm_set_minute [==========] 5 / 7 tests passed. [ FAILED ] > [...] and rtc-range > (https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/rtc-tools.git/tree/rtc-range.c) # ./rtc-range Testing 1970-01-01 00:00:00. KO Read back 2226-01-01 00:01:00. Testing 2000-02-28 23:59:59. KO Read back 2000-02-28 23:28:23. Testing 2020-02-28 23:59:59. KO Read back 2020-02-28 23:28:23. Testing 2038-01-19 03:14:07. KO Read back 2038-01-19 03:19:03. Testing 2069-12-31 23:59:59. KO Read back 2069-12-31 23:31:23. Testing 2079-12-31 23:59:59. KO Read back 2079-12-31 23:31:23. Testing 2099-12-31 23:59:59. KO Read back 2099-12-31 23:31:23. Testing 2255-12-31 23:59:59. KO Read back 2255-12-31 23:31:23. Testing 2100-02-28 23:59:59. KO Read back 2100-02-28 23:28:23. Testing 2106-02-07 06:28:15. KO Read back 2106-02-07 06:07:06. Testing 2262-04-11 23:47:16. KO Read back 2006-04-11 23:11:23. Something is very wrong here. I'll try to fix the failures in rtctest and the problems in rtc-range before version 2 of the patchset. (The 2255 date was my addition, because I suspect this to be the upper limit of the RTC's range.) [...] > > +config RTC_DRV_NTXEC > > + tristate "Netronix embedded controller RTC driver" > > + depends on MFD_NTXEC > > + > > This should get an help section. Ok, I'll add one. [...] > > +#include <linux/rtc.h> > > +#include <linux/mfd/ntxec.h> > > +#include <linux/platform_device.h> > > +#include <linux/types.h> > > +#include <linux/module.h> > > +#include <linux/of_device.h> > > Please sort the includes. Will do. [...] > > + rtcdev = devm_rtc_device_register(&pdev->dev, "ntxec-rtc", > > + &ntxec_rtc_ops, THIS_MODULE); > > Please use devm_rtc_allocate_device and rtc_register_device. Also, set > the supported range (->range_min and ->range_max). Ok, will do. Thanks for the review and the testing tips. Jonathan Neuschäfer
Attachment:
signature.asc
Description: PGP signature
