Re: [PATCH 1/2] spi: Add the SPI daisy chain support.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Adrian,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on spi/for-next]
[also build test WARNING on v5.8-rc3 next-20200703]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Adrian-Fiergolski/spi-Add-the-SPI-daisy-chain-support/20200703-221615
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: parisc-allyesconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/spi/spi-daisy_chain.c:232:6: warning: no previous prototype for 'spi_daisy_chain_clean' [-Wmissing-prototypes]
     232 | void spi_daisy_chain_clean(struct list_head *daisy_chain_devs)
         |      ^~~~~~~~~~~~~~~~~~~~~

vim +/spi_daisy_chain_clean +232 drivers/spi/spi-daisy_chain.c

   231	
 > 232	void spi_daisy_chain_clean(struct list_head *daisy_chain_devs)
   233	{
   234		struct spi_device *spi_dev;
   235		struct spi_daisy_chain_device *spi_chain_dev;
   236	
   237		list_for_each_entry(spi_chain_dev, daisy_chain_devs, devices) {
   238			spi_dev = spi_chain_dev->spi;
   239			spi_dev_put(spi_dev);
   240			kfree(spi_chain_dev->no_operation.tx_buf);
   241			kfree(spi_chain_dev);
   242		}
   243		list_del(daisy_chain_devs);
   244		kfree(daisy_chain_devs);
   245	}
   246	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux