On 03/07/2020 06:38, kernelci.org bot wrote: Hi Guillaume, is this report legit? The situation didn't change from Monday, I just repeated the test with mainline compared to my patch reverted. What is the actual failure here? You pointed to: <2>GIC CPU mask not found - kernel will fail to boot. but I don't see any explicit line stating that as the culprit anywhere in the logs. Actually the last line says: 00:24:07.022224 Job finished correctly And I see the GIC messages with and without this patch. As mentioned on Monday, "-smp 2" should be added to the QEMU command line to fix that. > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * > * This automated bisection report was sent to you on the basis * > * that you may be involved with the breaking commit it has * > * found. No manual investigation has been done to verify it, * > * and the root cause of the problem may be somewhere else. * > * * > * If you do send a fix, please include this trailer: * > * Reported-by: "kernelci.org bot" <bot@xxxxxxxxxxxx> * > * * > * Hope this helps! * > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * > > mainline/master bisection: baseline.dmesg.crit on qemu_arm-vexpress-a15 > > Summary: > Start: 7cc2a8ea1048 Merge tag 'block-5.8-2020-07-01' of git://git.kernel.dk/linux-block > Plain log: https://storage.kernelci.org/mainline/master/v5.8-rc3-37-g7cc2a8ea1048/arm/vexpress_defconfig/gcc-8/lab-cip/baseline-vexpress-v2p-ca15-tc1.txt > HTML log: https://storage.kernelci.org/mainline/master/v5.8-rc3-37-g7cc2a8ea1048/arm/vexpress_defconfig/gcc-8/lab-cip/baseline-vexpress-v2p-ca15-tc1.html > Result: 38ac46002d1d arm: dts: vexpress: Move mcc node back into motherboard node > > Checks: > revert: PASS > verify: PASS What does that mean? That reverting the patch made the test pass? I did exactly that, and reverting made it worse, because poweroff doesn't work (among other things). So could this be a testing artifact? Because of the failing poweroff the test timed out or something? Many thanks, Andre > > Parameters: > Tree: mainline > URL: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > Branch: master > Target: qemu_arm-vexpress-a15 > CPU arch: arm > Lab: lab-cip > Compiler: gcc-8 > Config: vexpress_defconfig > Test case: baseline.dmesg.crit > > Breaking commit found: > > ------------------------------------------------------------------------------- > commit 38ac46002d1df5707566a73486452851341028d2 > Author: Andre Przywara <andre.przywara@xxxxxxx> > Date: Wed Jun 3 17:22:37 2020 +0100 > > arm: dts: vexpress: Move mcc node back into motherboard node > > Commit d9258898ad49 ("arm64: dts: arm: vexpress: Move fixed devices > out of bus node") moved the "mcc" DT node into the root node, because > it does not have any children using "reg" properties, so does violate > some dtc checks about "simple-bus" nodes. > > However this broke the vexpress config-bus code, which walks up the > device tree to find the first node with an "arm,vexpress,site" property. > This gave the wrong result (matching the root node instead of the > motherboard node), so broke the clocks and some other devices for > VExpress boards. > > Move the whole node back into its original position. This re-introduces > the dtc warning, but is conceptually the right thing to do. The dtc > warning seems to be overzealous here, there are discussions on fixing or > relaxing this check instead. > > Link: https://lore.kernel.org/r/20200603162237.16319-1-andre.przywara@xxxxxxx > Fixes: d9258898ad49 ("arm64: dts: vexpress: Move fixed devices out of bus node") > Reported-and-tested-by: Guenter Roeck <linux@xxxxxxxxxxxx> > Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx> > Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx> > > diff --git a/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi b/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi > index e6308fb76183..a88ee5294d35 100644 > --- a/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi > +++ b/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi > @@ -100,79 +100,6 @@ > }; > }; > > - mcc { > - compatible = "arm,vexpress,config-bus"; > - arm,vexpress,config-bridge = <&v2m_sysreg>; > - > - oscclk0 { > - /* MCC static memory clock */ > - compatible = "arm,vexpress-osc"; > - arm,vexpress-sysreg,func = <1 0>; > - freq-range = <25000000 60000000>; > - #clock-cells = <0>; > - clock-output-names = "v2m:oscclk0"; > - }; > - > - v2m_oscclk1: oscclk1 { > - /* CLCD clock */ > - compatible = "arm,vexpress-osc"; > - arm,vexpress-sysreg,func = <1 1>; > - freq-range = <23750000 65000000>; > - #clock-cells = <0>; > - clock-output-names = "v2m:oscclk1"; > - }; > - > - v2m_oscclk2: oscclk2 { > - /* IO FPGA peripheral clock */ > - compatible = "arm,vexpress-osc"; > - arm,vexpress-sysreg,func = <1 2>; > - freq-range = <24000000 24000000>; > - #clock-cells = <0>; > - clock-output-names = "v2m:oscclk2"; > - }; > - > - volt-vio { > - /* Logic level voltage */ > - compatible = "arm,vexpress-volt"; > - arm,vexpress-sysreg,func = <2 0>; > - regulator-name = "VIO"; > - regulator-always-on; > - label = "VIO"; > - }; > - > - temp-mcc { > - /* MCC internal operating temperature */ > - compatible = "arm,vexpress-temp"; > - arm,vexpress-sysreg,func = <4 0>; > - label = "MCC"; > - }; > - > - reset { > - compatible = "arm,vexpress-reset"; > - arm,vexpress-sysreg,func = <5 0>; > - }; > - > - muxfpga { > - compatible = "arm,vexpress-muxfpga"; > - arm,vexpress-sysreg,func = <7 0>; > - }; > - > - shutdown { > - compatible = "arm,vexpress-shutdown"; > - arm,vexpress-sysreg,func = <8 0>; > - }; > - > - reboot { > - compatible = "arm,vexpress-reboot"; > - arm,vexpress-sysreg,func = <9 0>; > - }; > - > - dvimode { > - compatible = "arm,vexpress-dvimode"; > - arm,vexpress-sysreg,func = <11 0>; > - }; > - }; > - > bus@8000000 { > motherboard-bus { > model = "V2M-P1"; > @@ -435,6 +362,79 @@ > }; > }; > }; > + > + mcc { > + compatible = "arm,vexpress,config-bus"; > + arm,vexpress,config-bridge = <&v2m_sysreg>; > + > + oscclk0 { > + /* MCC static memory clock */ > + compatible = "arm,vexpress-osc"; > + arm,vexpress-sysreg,func = <1 0>; > + freq-range = <25000000 60000000>; > + #clock-cells = <0>; > + clock-output-names = "v2m:oscclk0"; > + }; > + > + v2m_oscclk1: oscclk1 { > + /* CLCD clock */ > + compatible = "arm,vexpress-osc"; > + arm,vexpress-sysreg,func = <1 1>; > + freq-range = <23750000 65000000>; > + #clock-cells = <0>; > + clock-output-names = "v2m:oscclk1"; > + }; > + > + v2m_oscclk2: oscclk2 { > + /* IO FPGA peripheral clock */ > + compatible = "arm,vexpress-osc"; > + arm,vexpress-sysreg,func = <1 2>; > + freq-range = <24000000 24000000>; > + #clock-cells = <0>; > + clock-output-names = "v2m:oscclk2"; > + }; > + > + volt-vio { > + /* Logic level voltage */ > + compatible = "arm,vexpress-volt"; > + arm,vexpress-sysreg,func = <2 0>; > + regulator-name = "VIO"; > + regulator-always-on; > + label = "VIO"; > + }; > + > + temp-mcc { > + /* MCC internal operating temperature */ > + compatible = "arm,vexpress-temp"; > + arm,vexpress-sysreg,func = <4 0>; > + label = "MCC"; > + }; > + > + reset { > + compatible = "arm,vexpress-reset"; > + arm,vexpress-sysreg,func = <5 0>; > + }; > + > + muxfpga { > + compatible = "arm,vexpress-muxfpga"; > + arm,vexpress-sysreg,func = <7 0>; > + }; > + > + shutdown { > + compatible = "arm,vexpress-shutdown"; > + arm,vexpress-sysreg,func = <8 0>; > + }; > + > + reboot { > + compatible = "arm,vexpress-reboot"; > + arm,vexpress-sysreg,func = <9 0>; > + }; > + > + dvimode { > + compatible = "arm,vexpress-dvimode"; > + arm,vexpress-sysreg,func = <11 0>; > + }; > + }; > }; > }; > }; > ------------------------------------------------------------------------------- > > > Git bisection log: > > ------------------------------------------------------------------------------- > git bisect start > # good: [719fdd32921fb7e3208db8832d32ae1c2d68900f] afs: Fix storage of cell names > git bisect good 719fdd32921fb7e3208db8832d32ae1c2d68900f > # bad: [7cc2a8ea104820dd9e702202621e8fd4d9f6c8cf] Merge tag 'block-5.8-2020-07-01' of git://git.kernel.dk/linux-block > git bisect bad 7cc2a8ea104820dd9e702202621e8fd4d9f6c8cf > # bad: [e44b59cd758acdd413512d4597a1fabdadfe3abf] Merge tag 'arm-fixes-5.8-1' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc > git bisect bad e44b59cd758acdd413512d4597a1fabdadfe3abf > # good: [91a9a90d040e8b9ff63d48ea71468e0f4db764ff] Merge tag 'sched_urgent_for_5.8_rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip > git bisect good 91a9a90d040e8b9ff63d48ea71468e0f4db764ff > # bad: [42d3f7e8da1bc55e3109f612c519c945f6587194] Merge tag 'imx-fixes-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux into arm/fixes > git bisect bad 42d3f7e8da1bc55e3109f612c519c945f6587194 > # bad: [6d89c73ca5813768a2cc66f7420ac0cbddf4f37d] Merge tag 'arm-soc/for-5.8/soc-fixes' of https://github.com/Broadcom/stblinux into arm/fixes > git bisect bad 6d89c73ca5813768a2cc66f7420ac0cbddf4f37d > # bad: [0f77ce26ebcf6ea384421d2dd47b924b83649692] Revert "ARM: sti: Implement dummy L2 cache's write_sec" > git bisect bad 0f77ce26ebcf6ea384421d2dd47b924b83649692 > # bad: [d68ec1644dd546851d651787a638aead32a60a6f] Merge tag 'juno-fix-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux into arm/fixes > git bisect bad d68ec1644dd546851d651787a638aead32a60a6f > # bad: [38ac46002d1df5707566a73486452851341028d2] arm: dts: vexpress: Move mcc node back into motherboard node > git bisect bad 38ac46002d1df5707566a73486452851341028d2 > # first bad commit: [38ac46002d1df5707566a73486452851341028d2] arm: dts: vexpress: Move mcc node back into motherboard node > ------------------------------------------------------------------------------- >
