On Thu, Jul 02, 2020 at 02:51:43PM -0600, Rob Herring wrote: > On Wed, 01 Jul 2020 18:29:17 +0200, Ondrej Jirman wrote: > > Convert Rocktech MIPI DSI panel driver from txt to yaml bindings. > > > > Signed-off-by: Ondrej Jirman <megous@xxxxxxxxxx> > > --- > > .../display/panel/rocktech,jh057n00900.txt | 23 ------- > > .../display/panel/rocktech,jh057n00900.yaml | 66 +++++++++++++++++++ > > 2 files changed, 66 insertions(+), 23 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt > > create mode 100644 Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: '#address-cells', '#size-cells', 'port@0' do not match any of the regexes: 'pinctrl-[0-9]+' > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'vcc-supply' is a required property > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'iovcc-supply' is a required property > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'reset-gpios' is a required property Paths look bogus ^^^^ It should be .../rocktech,jh057n00900.yaml: ... regards, o. > > See https://patchwork.ozlabs.org/patch/1320690 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > Please check and re-submit. >