On 7/2/20 9:56 AM, Chanwoo Choi wrote: > Hi Dmitry, > > On 6/9/20 10:13 PM, Dmitry Osipenko wrote: >> Tegra EMC driver was turned into a regular kernel driver, it also could >> be compiled as a loadable kernel module now. Hence EMC clock isn't > > Looks good to me. But, you better to add the commit information > about Tegra EMC driver with commit-id ("patch title") format > into patch descritpion. > >> guaranteed to be available and clk_get("emc") may return -EPROBE_DEFER and >> there is no good reason to spam KMSG with a error about missing EMC clock >> in this case, so let's silence the deferred probe error. >> >> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> >> --- >> drivers/devfreq/tegra20-devfreq.c | 8 +++++--- >> 1 file changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/devfreq/tegra20-devfreq.c b/drivers/devfreq/tegra20-devfreq.c >> index ff82bac9ee4e..6469dc69c5e0 100644 >> --- a/drivers/devfreq/tegra20-devfreq.c >> +++ b/drivers/devfreq/tegra20-devfreq.c >> @@ -141,9 +141,11 @@ static int tegra_devfreq_probe(struct platform_device *pdev) >> >> /* EMC is a system-critical clock that is always enabled */ >> tegra->emc_clock = devm_clk_get(&pdev->dev, "emc"); >> - if (IS_ERR(tegra->emc_clock)) { >> - err = PTR_ERR(tegra->emc_clock); >> - dev_err(&pdev->dev, "failed to get emc clock: %d\n", err); >> + err = PTR_ERR_OR_ZERO(tegra->emc_clock); >> + if (err) { >> + if (err != -EPROBE_DEFER) >> + dev_err(&pdev->dev, "failed to get emc clock: %d\n", >> + err); >> return err; >> } >> >> > > The Tegra EMC drive is included in this patchset. So, don't need to mention the commit info. Looks good to me. Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> -- Best Regards, Chanwoo Choi Samsung Electronics