Hi,
On Wed, Jul 01, 2020 at 12:31:20PM +0200, Ondrej Jirman wrote:
> It's better than having it spread around the driver.
Reviewed-by: Guido Günther <agx@xxxxxxxxxxx>
>
> Signed-off-by: Ondrej Jirman <megous@xxxxxxxxxx>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> drivers/gpu/drm/panel/panel-sitronix-st7703.c | 50 +++++++++----------
> 1 file changed, 25 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> index 08cbc316266c..d03aab10cfef 100644
> --- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> +++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
> @@ -153,6 +153,31 @@ static int jh057n_init_sequence(struct st7703 *ctx)
> return 0;
> }
>
> +static const struct drm_display_mode jh057n00900_mode = {
> + .hdisplay = 720,
> + .hsync_start = 720 + 90,
> + .hsync_end = 720 + 90 + 20,
> + .htotal = 720 + 90 + 20 + 20,
> + .vdisplay = 1440,
> + .vsync_start = 1440 + 20,
> + .vsync_end = 1440 + 20 + 4,
> + .vtotal = 1440 + 20 + 4 + 12,
> + .vrefresh = 60,
> + .clock = 75276,
> + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> + .width_mm = 65,
> + .height_mm = 130,
> +};
> +
> +struct st7703_panel_desc jh057n00900_panel_desc = {
> + .mode = &jh057n00900_mode,
> + .lanes = 4,
> + .mode_flags = MIPI_DSI_MODE_VIDEO |
> + MIPI_DSI_MODE_VIDEO_BURST | MIPI_DSI_MODE_VIDEO_SYNC_PULSE,
> + .format = MIPI_DSI_FMT_RGB888,
> + .init_sequence = jh057n_init_sequence,
> +};
> +
> static int st7703_enable(struct drm_panel *panel)
> {
> struct st7703 *ctx = panel_to_st7703(panel);
> @@ -226,31 +251,6 @@ static int st7703_prepare(struct drm_panel *panel)
> return ret;
> }
>
> -static const struct drm_display_mode jh057n00900_mode = {
> - .hdisplay = 720,
> - .hsync_start = 720 + 90,
> - .hsync_end = 720 + 90 + 20,
> - .htotal = 720 + 90 + 20 + 20,
> - .vdisplay = 1440,
> - .vsync_start = 1440 + 20,
> - .vsync_end = 1440 + 20 + 4,
> - .vtotal = 1440 + 20 + 4 + 12,
> - .vrefresh = 60,
> - .clock = 75276,
> - .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> - .width_mm = 65,
> - .height_mm = 130,
> -};
> -
> -struct st7703_panel_desc jh057n00900_panel_desc = {
> - .mode = &jh057n00900_mode,
> - .lanes = 4,
> - .mode_flags = MIPI_DSI_MODE_VIDEO |
> - MIPI_DSI_MODE_VIDEO_BURST | MIPI_DSI_MODE_VIDEO_SYNC_PULSE,
> - .format = MIPI_DSI_FMT_RGB888,
> - .init_sequence = jh057n_init_sequence,
> -};
> -
> static int st7703_get_modes(struct drm_panel *panel,
> struct drm_connector *connector)
> {
> --
> 2.27.0
>
