On 18/06/2020 00:32, Serge Semin wrote:
> Add Thomas and myself as maintainers of the MIPS CPU and GIC IRQchip, MIPS
> GIC timer and MIPS CPS CPUidle drivers.
Why will you add yourself in the MAINTAINERS file for those drivers when
git shows just one contribution for the mips-gic-timer for the timer
stability ?
git shortlog --numbered --summary drivers/cpuidle/cpuidle-cps.c
4 Paul Burton
1 Daniel Lezcano
1 Marcin Nowakowski
1 Matt Redfearn
1 Thomas Gleixner
git shortlog --numbered --summary drivers/clocksource/mips-gic-timer.c
11 Andrew Bresticker
4 Ezequiel Garcia
4 Matt Redfearn
4 Paul Burton
3 Daniel Lezcano
3 Thomas Gleixner
2 Linus Torvalds
1 Alex Smith
1 Christophe Jaillet
1 Felix Fietkau
1 Ingo Molnar
1 Markos Chandras
1 Paul Gortmaker
1 Rafał Miłecki
1 Richard Cochran
1 Serge Semin
1 Viresh Kumar
1 YueHaibing
Also, in the cpuidle-cps.c history, there is no signed-off from Rafael,
neither an Acked-by when it was merged. That make me think the patch
went through another path than the linux-pm tree without a cpuidle
framework maintainer acknowledgement.
Perhaps it is a mistake and the patch was actually acked-by, but I would
like to remind the patches have to be acked by the upper maintainers and
being listed in the MAINTAINERS file does not give the right of override
this rule.
> Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>
> Acked-by: Marc Zyngier <maz@xxxxxxxxxx>
> Cc: Alexey Malahov <Alexey.Malahov@xxxxxxxxxxxxxxxxxxxx>
> Cc: linux-mips@xxxxxxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx
>
> ---
>
> Changelog v3:
> - Keep the files list alphabetically ordered.
> - Add Thomas as the co-maintainer of the designated drivers.
> ---
> MAINTAINERS | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2926327e4976..20532e0287d7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11278,6 +11278,17 @@ F: arch/mips/configs/generic/board-boston.config
> F: drivers/clk/imgtec/clk-boston.c
> F: include/dt-bindings/clock/boston-clock.h
>
> +MIPS CORE DRIVERS
> +M: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
> +M: Serge Semin <fancer.lancer@xxxxxxxxx>
> +L: linux-mips@xxxxxxxxxxxxxxx
> +S: Supported
> +F: drivers/bus/mips_cdmm.c
> +F: drivers/clocksource/mips-gic-timer.c
> +F: drivers/cpuidle/cpuidle-cps.c
> +F: drivers/irqchip/irq-mips-cpu.c
> +F: drivers/irqchip/irq-mips-gic.c
> +
> MIPS GENERIC PLATFORM
> M: Paul Burton <paulburton@xxxxxxxxxx>
> L: linux-mips@xxxxxxxxxxxxxxx
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
