On Thu, May 29, 2014 at 9:54 AM, Lee Jones <lee.jones@xxxxxxxxxx> wrote: >> diff --git a/include/dt-bindings/mfd/qcom_rpm.h b/include/dt-bindings/mfd/qcom_rpm.h >> new file mode 100644 >> index 0000000..277e789 >> --- /dev/null >> +++ b/include/dt-bindings/mfd/qcom_rpm.h >> @@ -0,0 +1,142 @@ >> +/* >> + * This header provides constants for the Qualcomm RPM bindings. >> + */ > > Proper header please. Will do. > >> +#ifndef _DT_BINDINGS_MFD_QCOM_RPM_H >> +#define _DT_BINDINGS_MFD_QCOM_RPM_H >> + >> +#define QCOM_RPM_APPS_FABRIC_ARB 1 >> +#define QCOM_RPM_APPS_FABRIC_CLK 2 >> +#define QCOM_RPM_APPS_FABRIC_HALT 3 > > [...] > >> +#define QCOM_RPM_SYS_FABRIC_MODE 131 >> +#define QCOM_RPM_USB_OTG_SWITCH 132 >> +#define QCOM_RPM_VDDMIN_GPIO 133 > > Are you sure you don't want these in 0xXY format? This is just a list of virtual identifiers, so unless you object to much I'll leave them in base 10. Thanks, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html