Hi Laurent, Thanks for your patch. On 2020-06-21 03:47:29 +0300, Laurent Pinchart wrote: > The resets and iommus properties are used in DT sources in the kernel > tree. Document them, and make resets mandatory. The iommus property is > optional as not all platforms wire the FCP to a functional IOMMU. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/media/renesas,fcp.yaml | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml > index eeca7e255420..b6cf2958e6c9 100644 > --- a/Documentation/devicetree/bindings/media/renesas,fcp.yaml > +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml > @@ -31,14 +31,21 @@ properties: > clocks: > maxItems: 1 > > + iommus: > + maxItems: 1 > + > power-domains: > maxItems: 1 > > + resets: > + maxItems: 1 > + > required: > - compatible > - reg > - clocks > - power-domains > + - resets > > additionalProperties: false > > @@ -53,5 +60,7 @@ examples: > reg = <0xfea2f000 0x200>; > clocks = <&cpg CPG_MOD 602>; > power-domains = <&sysc R8A7795_PD_ALWAYS_ON>; > + resets = <&cpg 602>; > + iommus = <&ipmmu_vi0 9>; > }; > ... > -- > Regards, > > Laurent Pinchart > -- Regards, Niklas Söderlund