Re: [PATCH v5 4/6] memory: stm32-fmc2-ebi: add STM32 FMC2 EBI controller driver

[Christophe Kerello <christophe.kerello@xxxxxx>]

Hi Richard,

On 6/30/20 11:13 AM, Richard Weinberger wrote:
> On Fri, Jun 12, 2020 at 5:24 PM Christophe Kerello
> <christophe.kerello@xxxxxx> wrote:
> > The driver adds the support for the STMicroelectronics FMC2 EBI controller
> > found on STM32MP SOCs.
> >
> > Signed-off-by: Christophe Kerello <christophe.kerello@xxxxxx>
> > ---
> > +       if (!IS_ERR(rstc)) {
> > +               reset_control_assert(rstc);
> > +               reset_control_deassert(rstc);
>
> Shouldn't there be a small delay between assert and deassert?
> Other than that the code looks good to me.

Even if I have currently not met any issue, I will add a udelay(2) to be 
safe. It will be part of v6.

Thanks,
Christophe Kerello.