Hi Matthias,
Thank you for you review.
On 22/6/20 12:14, Matthias Brugger wrote:
>
>
> On 19/06/2020 12:27, Enric Balletbo i Serra wrote:
>> Remove the unit address from the DT nodes that doesn't have a reg
>> property. This fixes the following unit name warnings:
>>
>> Warning (unit_address_vs_reg): /cpus/idle-states/cluster-sleep@0: node has a unit name, but no reg or ranges property
>> Warning (unit_address_vs_reg): /cpus/idle-states/cluster-sleep@1: node has a unit name, but no reg or ranges property
>>
>> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
>> ---
>>
>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> index 00137ec61164d..e356076749148 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> @@ -168,7 +168,7 @@ CPU_SLEEP: cpu-sleep {
>> min-residency-us = <800>;
>> };
>>
>> - CLUSTER_SLEEP0: cluster-sleep@0 {
>> + CLUSTER_SLEEP0: cluster-sleep0 {
>
> Should be:
> cluster-sleep-0
>
Ack, I'll change in next version
>> compatible = "arm,idle-state";
>> local-timer-stop;
>> arm,psci-suspend-param = <0x01010001>;
>> @@ -176,7 +176,7 @@ CLUSTER_SLEEP0: cluster-sleep@0 {
>> exit-latency-us = <400>;
>> min-residency-us = <1000>;
>> };
>> - CLUSTER_SLEEP1: cluster-sleep@1 {
>> + CLUSTER_SLEEP1: cluster-sleep1 {
>
> Same here.
>
Ack.
> Regards,
> Matthias1
>
>> compatible = "arm,idle-state";
>> local-timer-stop;
>> arm,psci-suspend-param = <0x01010001>;
>>
