On 2020/6/24, Leo Li <leoyang.li@xxxxxxx> wrote:
> -----Original Message-----
> From: Leo Li <leoyang.li@xxxxxxx>
> Sent: 2020年6月24日 7:12
> To: Qiang Zhao <qiang.zhao@xxxxxxx>; shawnguo@xxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Qiang Zhao
> <qiang.zhao@xxxxxxx>; Xiaowei Bao <xiaowei.bao@xxxxxxx>
> Subject: RE: [RESEND PATCH] arm64: dts: ls1028a: Add DSPI nodes
>
>
>
> > -----Original Message-----
> > From: Qiang Zhao <qiang.zhao@xxxxxxx>
> > Sent: Monday, June 22, 2020 3:29 AM
> > To: shawnguo@xxxxxxxxxx
> > Cc: devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Leo Li
> > <leoyang.li@xxxxxxx>; Qiang Zhao <qiang.zhao@xxxxxxx>; Xiaowei Bao
> > <xiaowei.bao@xxxxxxx>
> > Subject: [RESEND PATCH] arm64: dts: ls1028a: Add DSPI nodes
>
> This patch is actually defining dspi flash nodes for LS1028a-qds board instead
> of adding dspi nodes for the soc.
Thank you! Will correct next version.
>
> >
> > From: Xiaowei Bao <xiaowei.bao@xxxxxxx>
> >
> > Add the DSPI nodes for ls1028a.
> >
> > Signed-off-by: Xiaowei Bao <xiaowei.bao@xxxxxxx>
> > Signed-off-by: Zhao Qiang <qiang.zhao@xxxxxxx>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts | 85
> > +++++++++++++++++++++++
> > 1 file changed, 85 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > index dd69c5b..e4f00c2 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-qds.dts
> > @@ -107,6 +107,91 @@
> > };
> > };
> >
> > +&dspi0 {
> > + bus-num = <0>;
> > + status = "okay";
> > +
> > + flash@0 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "jedec,spi-nor";
> > + spi-cpol;
> > + spi-cpha;
> > + reg = <0>;
> > + spi-max-frequency = <10000000>;
> > + };
> > +
> > + flash@1 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "jedec,spi-nor";
> > + spi-cpol;
> > + spi-cpha;
> > + reg = <1>;
> > + spi-max-frequency = <10000000>;
> > + };
> > +
> > + flash@2 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "jedec,spi-nor";
> > + spi-cpol;
> > + spi-cpha;
> > + reg = <2>;
> > + spi-max-frequency = <10000000>;
> > + };
> > +};
> > +
> > +&dspi1 {
> > + bus-num = <1>;
> > + status = "okay";
> > +
> > + flash@0 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
>
> These probably are not needed when no sub nodes are defined.
>
> > + compatible = "jedec,spi-nor";
> > + spi-cpol;
> > + spi-cpha;
> > + reg = <0>;
> > + spi-max-frequency = <10000000>;
> > + };
> > +
> > + flash@1 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "jedec,spi-nor";
> > + spi-cpol;
> > + spi-cpha;
> > + reg = <1>;
> > + spi-max-frequency = <10000000>;
> > + };
> > +
> > + flash@2 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "jedec,spi-nor";
> > + spi-cpol;
> > + spi-cpha;
> > + reg = <2>;
> > + spi-max-frequency = <10000000>;
> > + };
> > +};
> > +
> > +&dspi2 {
> > + bus-num = <2>;
> > + status = "okay";
> > +
> > + flash@0 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "jedec,spi-nor";
> > + spi-cpol;
> > + spi-cpha;
> > + reg = <0>;
> > + spi-max-frequency = <10000000>;
> > + };
> > +};
> > +
> > &duart0 {
> > status = "okay";
> > };
> > --
> > 2.7.4
Best Regards
Qiang Zhao
