Re: [PATCH 01/10] dt/bindings: add passthru-mask property to versatile-fpga-irq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Fri, May 23, 2014 at 8:00 AM, Rob Herring <robherring2@xxxxxxxxx> wrote:
> On Fri, May 23, 2014 at 7:46 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>> On Tue, May 20, 2014 at 11:09 PM, Rob Herring <robherring2@xxxxxxxxx> wrote:
>>
>>> From: Rob Herring <robh@xxxxxxxxxx>
>>>
>>> Add a passthru-mask property for setting interrupts which are passed
>>> through directly to a primary controller.
>>>
>>> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
>>> Cc: Pawel Moll <pawel.moll@xxxxxxx>
>>> Cc: Mark Rutland <mark.rutland@xxxxxxx>
>>> Cc: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx>
>>> Cc: Kumar Gala <galak@xxxxxxxxxxxxxx>
>>> ---
>>>  Documentation/devicetree/bindings/arm/versatile-fpga-irq.txt | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/versatile-fpga-irq.txt b/Documentation/devicetree/bindings/arm/versatile-fpga-irq.txt
>>> index c9cf605..956b71d 100644
>>> --- a/Documentation/devicetree/bindings/arm/versatile-fpga-irq.txt
>>> +++ b/Documentation/devicetree/bindings/arm/versatile-fpga-irq.txt
>>> @@ -34,3 +34,6 @@ Optional properties:
>>>  - interrupts: if the FPGA IRQ controller is cascaded, i.e. if its IRQ
>>>    output is simply connected to the input of another IRQ controller,
>>>    then the parent IRQ shall be specified in this property.
>>> +- passthru-mask: a u32 number representing a bit mas determining which of
>>
>> bit mask
>>
>> (speling)
>>
>>> +  the interrupts are directly passed through to the primary interrupt
>>> +  controller.
>>
>> This is very confusing on the Integrators. The FPGA IRQ controller
>> *is* the primary interrupt controller on these.
>
> Yes. Really, the h/w is not the same and we should have different
> compatible strings. Unfortunately, it is Integrator that should
> change.

I don't know what I was thinking... The compatible strings are
different as Versatile uses arm,versatile-sic, so I can drop this
passthru-mask.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux