From: Dan Murphy <dmurphy@xxxxxx> Date: Fri, 19 Jun 2020 11:18:10 -0500 > +s32 phy_get_internal_delay(struct phy_device *phydev, struct device *dev, > + const int *delay_values, int size, bool is_rx) > +{ > + int i; > + s32 delay; Please use reverse christmas tree ordering for local variables.