Hi Dan, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Dan-Murphy/RGMII-Internal-delay-common-property/20200619-051238 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git cb8e59cc87201af93dfbb6c3dccc8fcad72a09c2 config: x86_64-defconfig (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 487ca07fcc75d52755c9fe2ee05bcb3b6eeeec44) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/net/phy/phy_device.c:2677:16: error: expected ';' after return statement return -EINVAL ^ ; 1 error generated. vim +2677 drivers/net/phy/phy_device.c 2660 2661 #if IS_ENABLED(CONFIG_OF_MDIO) 2662 static int phy_get_int_delay_property(struct device *dev, const char *name) 2663 { 2664 s32 int_delay; 2665 int ret; 2666 2667 ret = device_property_read_u32(dev, name, &int_delay); 2668 if (ret) 2669 return ret; 2670 2671 return int_delay; 2672 } 2673 #else 2674 static inline int phy_get_int_delay_property(struct device *dev, 2675 const char *name) 2676 { > 2677 return -EINVAL 2678 } 2679 #endif 2680 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip
