Hello Linus, On Tue, May 26, 2020 at 01:32:25PM +0200, Linus Walleij wrote: > Hi Ondrej, > [...] > > + dsi_dcs_write_seq(dsi, ST7703_CMD_SETGIP1, > > + 0x82, 0x10, 0x06, 0x05, 0xA2, 0x0A, 0xA5, 0x12, > > + 0x31, 0x23, 0x37, 0x83, 0x04, 0xBC, 0x27, 0x38, > > + 0x0C, 0x00, 0x03, 0x00, 0x00, 0x00, 0x0C, 0x00, > > + 0x03, 0x00, 0x00, 0x00, 0x75, 0x75, 0x31, 0x88, > > + 0x88, 0x88, 0x88, 0x88, 0x88, 0x13, 0x88, 0x64, > > + 0x64, 0x20, 0x88, 0x88, 0x88, 0x88, 0x88, 0x88, > > + 0x02, 0x88, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00); > > + dsi_dcs_write_seq(dsi, ST7703_CMD_SETGIP2, > > + 0x02, 0x21, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > + 0x00, 0x00, 0x00, 0x00, 0x02, 0x46, 0x02, 0x88, > > + 0x88, 0x88, 0x88, 0x88, 0x88, 0x64, 0x88, 0x13, > > + 0x57, 0x13, 0x88, 0x88, 0x88, 0x88, 0x88, 0x88, > > + 0x75, 0x88, 0x23, 0x14, 0x00, 0x00, 0x02, 0x00, > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x03, 0x0A, > > + 0xA5, 0x00, 0x00, 0x00, 0x00); > > + dsi_dcs_write_seq(dsi, ST7703_CMD_SETGAMMA, > > + 0x00, 0x09, 0x0D, 0x23, 0x27, 0x3C, 0x41, 0x35, > > + 0x07, 0x0D, 0x0E, 0x12, 0x13, 0x10, 0x12, 0x12, > > + 0x18, 0x00, 0x09, 0x0D, 0x23, 0x27, 0x3C, 0x41, > > + 0x35, 0x07, 0x0D, 0x0E, 0x12, 0x13, 0x10, 0x12, > > + 0x12, 0x18); > > + msleep(20); > > This stuff is really hard or impossible to understand without the > datasheet. > > In my previous review I wrote: > > It appears that the Himax HX8363 is using the same display controller > if you look at the datasheet: > http://www.datasheet-pdf.com/PDF/HX8369-A-Datasheet-Himax-729024 > There you find an explanation to some of the commands. It is st7703, and we have a fairly complete datasheet available publicly. I posted links in the cover letter. > That means, try to get rid of as much of the magic bytes as you can > and use proper #defines. I know it takes some work but the result > is so much more useful and readable. I've added some descriptions from the datasheet as comments next to the values in v4. Thank you and regards, o. > Further I wrote: > > You should definately insert code to read the MTP bytes: > 0xDA manufacturer > 0xDB driver version > 0xDC LCD module/driver > And print these, se e.g. my newly added NT35510 driver or > the Sony ACX424AKP driver. > > So please do that. > > Yours, > Linus Walleij > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe@xxxxxxxxxxxxxxxx. > To view this discussion on the web, visit https://groups.google.com/d/msgid/linux-sunxi/CACRpkdZpiQ7E_v-Gfk6vFcUEiMazvixYaL0ksKeP%3DTq3O6Fh%3DQ%40mail.gmail.com.
