Re: [PATCH v4] phy: Renesas R-Car Gen2 PHY driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hello.

On 05/27/2014 01:29 PM, Yoshihiro Shimoda wrote:

+Example (Lager board):
+
+	usb-phy@e6590100 {
+		compatible = "renesas,usb-phy-r8a7790";
+		reg = <0 0xe6590100 0 0x100>;
+		#phy-cells = <2>;
+		clocks = <&mstp7_clks R8A7790_CLK_HSUSB>;
+		clock-names = "usbhs";

I'm not sure about the clock-names string,
but the current clock-name of R8A7790_CLK_HSUSB

   I guess you meant "clock-output-names" prop?

is "hsusb" in r8a7790.dtsi.

   Yes. But it doesn't have to match to what's passed to devm_clk_get().

So, before I tested this driver, I changed the "hsusb" to "usbhs".
Otherwise, the devm_clk_get() in the driver failed.

   This is very strange, the driver works OK for me.

< snip >
+	for_each_child_of_node(dev->of_node, np) {
+  		struct rcar_gen2_phy *phy;

This line has two while spaces at the start of the line.

Thank you, looks like I cut&pasted from a bad source and forgot to run the patch thru scripts/checkpatch.pl...

Best regards,
Yoshihiro Shimoda

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux