Hi, Am Dienstag, 16. Juni 2020, 03:12:25 CEST schrieb David Miller: > From: David Miller <davem@xxxxxxxxxxxxx> > Date: Mon, 15 Jun 2020 18:11:29 -0700 (PDT) > > + return devm_phy_package_join(&phydev->mdio.dev, phydev, > > + vsc8531->base_addr, 0); > > But it is still dereferenced here. > > Did the compiler really not warn you about this when you test built > these changes? I'm wondering that myself ... it probably did and I overlooked it, which also is indicated by the fact that I did add the declaration of the vsc8531 when rebasing. > > Because you removed this devm_kzalloc() code, vsc8531 is never initialized. > > You also need to provide a proper header posting when you repost this series > after fixing this bug. not sure I understand what you mean with "header posting" here. Thanks Heiko
