On Tue, May 27, 2014 at 01:44:26PM +0100, Zhangfei Gao wrote:
> Signed-off-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx>
> ---
> .../bindings/net/hisilicon-hix5hd2-gmac.txt | 36 ++++++++++++++++++++
> 1 file changed, 36 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt
>
> diff --git a/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt b/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt
> new file mode 100644
> index 0000000..5fe3835
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/hisilicon-hix5hd2-gmac.txt
> @@ -0,0 +1,36 @@
> +Hisilicon hix5hd2 gmac controller
Just to clarify, is the SoC name "hix5hd2", or is the 'x' a wildcard?
> +
> +Required properties:
> +- compatible: should be "hisilicon,hix5hd2-gmac".
> +- reg: specifies base physical address(s) and size of the device registers.
> + The first region is the MAC register base and size.
> + The second region is external interface control register.
Single registers? Are these not part of a larger block?
> +- interrupts: should contain the MAC interrupts
How many, in which order?
> +- #address-cells: must be <1>.
> +- #size-cells: must be <0>.
> +- phy-mode: see ethernet.txt [1].
> +- phy-handle: see ethernet.txt [1].
> +- mac-address: see ethernet.txt [1].
> +- clocks: clock phandle and specifier pair.
Is this the only clock input to the gmac block?
Is the clock input named in any documentation?
Cheers,
Mark.
> +
> +- PHY subnode: inherits from phy binding [2]
> +
> +[1] Documentation/devicetree/bindings/net/ethernet.txt
> +[2] Documentation/devicetree/bindings/net/phy.txt
> +
> +Example:
> + gmac0: ethernet@f9840000 {
> + compatible = "hisilicon,hix5hd2-gmac";
> + reg = <0xf9840000 0x1000>,<0xf984300c 0x4>;
> + interrupts = <0 71 4>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + phy-mode = "mii";
> + phy-handle = <&phy2>;
> + mac-address = [00 00 00 00 00 00];
> + clocks = <&clock HIX5HD2_MAC0_CLK>;
> +
> + phy2: ethernet-phy@2 {
> + reg = <2>;
> + };
> + };
> --
> 1.7.9.5
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
