Am 11.06.20 um 19:06 schrieb Florian Fainelli: > > On 6/11/2020 9:52 AM, Maxime Ripard wrote: >> Hi Stefan, >> >> On Thu, Jun 11, 2020 at 05:50:30PM +0200, Stefan Wahren wrote: >>>> diff --git a/drivers/clk/bcm/clk-bcm2711-dvp.c b/drivers/clk/bcm/clk-bcm2711-dvp.c >>>> new file mode 100644 >>>> index 000000000000..84dbc886e303 >>>> --- /dev/null >>>> +++ b/drivers/clk/bcm/clk-bcm2711-dvp.c >>>> @@ -0,0 +1,120 @@ >>>> +// SPDX-License-Identifier: GPL-2.0-or-later >>>> +// Copyright 2020 Cerno >>>> + >>>> +#include <linux/clk-provider.h> >>>> +#include <linux/module.h> >>>> +#include <linux/platform_device.h> >>>> +#include <linux/reset-controller.h> >>>> +#include <linux/reset/reset-simple.h> >>>> + >>>> +#define DVP_HT_RPI_SW_INIT 0x04 >>>> +#define DVP_HT_RPI_MISC_CONFIG 0x08 >>> sorry for not noticing this before. Are these defines specific to the >>> Raspberry Pi, because of RPI? >> I'm not entirely sure to be honest. It's the names that the register >> have, but it's not clear to me if it's something specific to the RPi >> itself, or it just means something else entirely. > My understanding is that this is a wrapper that was done specifically > for the Raspberry Pi usage of that IP block, which is why it has PI in > the name, so this looks good correct, and this does match the internal > register database name. Okay, i'm fine with that and the whole series. Acked-by: Stefan Wahren <stefan.wahren@xxxxxxxx>
