Hi Andrey, On Sun, Jun 07, 2020 at 07:30:15PM +0300, Andrey Konovalov wrote: > This patchset adds improvements to the existing media driver for IMX290 > CMOS sensor from Sony. The major changes are adding 2 lane support, > configurable link frequency & pixel rate, test pattern generation, and > RAW12 mode support. Could you still see what checkpatch.pl says and address the style issues, please? Apart from those this seems fine to me. There are some on msleep() but I wouldn't worry about those. Thanks. -- Sakari Ailus