Hi, On 05/27/2014 10:07 AM, Maxime Ripard wrote: > On Mon, May 26, 2014 at 09:47:57AM +0200, Hans de Goede wrote: >> From: Chen-Yu Tsai <wens@xxxxxxxx> >> >> The sunxi pinctrl irq chip driver does not support wakeup at the >> moment. Adding IRQCHIP_SKIP_SET_WAKE lets the irqs work with drivers >> using wakeup. >> >> Also add a name to the irq chip. >> >> Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx> >> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> >> --- >> drivers/pinctrl/sunxi/pinctrl-sunxi.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c >> index db9ccd6..ec60c2e 100644 >> --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c >> +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c >> @@ -646,6 +646,8 @@ static struct irq_chip sunxi_pinctrl_irq_chip = { >> .irq_mask_ack = sunxi_pinctrl_irq_mask_ack, >> .irq_unmask = sunxi_pinctrl_irq_unmask, >> .irq_set_type = sunxi_pinctrl_irq_set_type, >> + .name = "sunxi-pio", >> + .flags = IRQCHIP_SKIP_SET_WAKE, > > I'd rather see the name set to dev_name() or something like that. This > will not work that great with multiple pin controller supporting > interrupts. That would require moving the irq_chip struct to become a member of the sunxi_pinctrl struct. Not undoable, but that seems like something which should be done in a separate patch. So shall I just drop the .name part of this patch for now ? Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html