On 6/9/2020 3:52 AM, Álvaro Fernández Rojas wrote: > BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller > to enable/disable certain components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas <noltari@xxxxxxxxx> > --- > .../devicetree/bindings/mips/brcm/soc.txt | 17 +++++++++++++++++ You should probably create a YAML binding from the beginning that way you get validation for free. This file should ultimately be broken down into separate YAML bindings, but I Have not had the time to do that yet (you are welcome to if you feel like it). Other than that, the binding definition looks good to me. -- Florian
