Hi mnlfie, thanks for your patch! On Fri, May 29, 2020 at 4:57 PM 乔星 <mnlife@xxxxxxxxxxx> wrote: > > From d25875d0a6808713f891fa5bafc313d50f317a52 Mon Sep 17 00:00:00 2001 > From: mnlife <mnlife@xxxxxxxxxxx> > Date: Fri, 29 May 2020 22:02:55 +0800 > Subject: [PATCH] gpiolib: Add some warn print for easier to debug > Content-Type: text/plain; charset="utf-8" > > when I get gpiod optional failed, I am Confused for a long time. > finally i find because of the string con_id is too long, > prop_name be truncated. > > Signed-off-by: mnlife <mnlife@xxxxxxxxxxx> This makes sense. > - char prop_name[32]; /* 32 is max size of property name */ > + char prop_name[48]; /* 48 is max size of property name */ But your patch also increase the allowed prop name to 48 from 32. What is this name really, why is it so long? I'd like to ask the DT maintainers what a proper length measure of the *-gpios property may be. The warning print is a good suggestion, please send a patch for just that. And another patch for extending the property length. Yours, Linus Walleij
