> -----Original Message-----
> From: Shevchenko, Andriy <andriy.shevchenko@xxxxxxxxx>
> Sent: Monday, June 8, 2020 6:08 PM
> To: Wan Mohamad, Wan Ahmad Zainie
> <wan.ahmad.zainie.wan.mohamad@xxxxxxxxx>
> Cc: kishon@xxxxxx; vkoul@xxxxxxxxxx; robh+dt@xxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Hunter, Adrian
> <adrian.hunter@xxxxxxxxx>
> Subject: Re: [PATCH v3 2/2] phy: intel: Add Keem Bay eMMC PHY support
>
> On Mon, Jun 08, 2020 at 04:15:01PM +0800, Wan Ahmad Zainie wrote:
> > Add support for eMMC PHY on Intel Keem Bay SoC.
>
> I think I commented on something already.
I don't recall any. May be on other similar patches.
I will wait for few days before sending next revision, if it is okay with you.
>
> ...
>
> > + if (ret) {
> > + dev_err(&phy->dev, "dllrdy failed, ret=%d\n", ret);
>
> > + return ret;
> > + }
> > +
> > + return 0;
>
> return ret;
I will change in next revision.
>
> ...
>
> > + if (IS_ERR(priv->emmcclk)) {
> > + dev_err(&phy->dev, "ERROR: getting emmcclk\n");
>
> > + return PTR_ERR(priv->emmcclk);
> > + }
> > +
> > + return 0;
>
> return PTR_ERR_OR_ZERO(...);
To clarify, I should replace the block above with,
return PTR_ERR_OR_ZERO(priv->emmcclk);
>
> ...
>
> > + priv->syscfg = devm_regmap_init_mmio(dev, base,
> > + &keembay_regmap_config);
>
> One line.
I will change in next revision.
>
> --
> With Best Regards,
> Andy Shevchenko
>
