Hi Simon, Rob, On Mon, May 26, 2014 at 9:48 AM, Simon Horman <horms@xxxxxxxxxxxx> wrote: >> > +Required properties: >> > +- compatible: "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC. >> > + "renesas,usb-phy-r8a7791" if the device is a part of R8A7791 SoC. >> >> As this is a new driver, I think you should switch to the recommended >> vendor/soc/device ordering, which is also supported by checkpatch (incl. >> wildcard matching!), i.e. "renesas,r8a7790-usb-phy" etc. > > A while ago we were asked to consolidate our drivers around a consistent > scheme. At the time the <vendor>,<device>-<version> scheme, where version = (after talking around at ELC) It's my understanding this was a silly mistake. > SoC for most Renesas parts, was agreed to be acceptable and we have > (hopefully) consistently been using that ever since. We did for everything except for clock drivers, sound, and thermal. > So unless there has been a policy change I would prefer to keep using this > scheme (i.e. leave the bindings above as-is). And update checkpatch if that > is appropriate. Rob, can we have the official policy documented in Documentation/devicetree/bindings? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html