>> + /* Enable the lock bits on all PLLs */ >> + for (i = 0; i < ARRAY_SIZE(pll_regs); i++) { >> + val = readl(reg + pll_regs[i]); >> + val |= BIT(29); > >Having a define for that would be nice here > >> + writel(val, reg + pll_regs[i]); >> + } >> + >> + /* >> + * In order to pass the EMI certification, the SDM function of >> + * the peripheral 1 bus is enabled, and the frequency is still >> + * calculated using the previous division factor. >> + */ >> + writel(0xd1303333, reg + SUN50I_A100_PLL_PERIPH1_PATTERN0_REG); > >Same here Having a define? I don’t quite understand what you mean, can you give me an example? MBR, Yangtao