Hi, On Fri, May 29, 2020 at 06:27:04PM +0200, Pavel Machek wrote: > > This patchset improves support for SBS compliant batteries. Due to > > the changes, the battery now exposes 32 power supply properties and > > (un)plugging it generates a backtrace containing the following message > > without the first patch in this series: > > > > --------------------------- > > WARNING: CPU: 0 PID: 20 at lib/kobject_uevent.c:659 add_uevent_var+0xd4/0x104 > > add_uevent_var: too many keys > > --------------------------- > > > > For references this is what an SBS battery status looks like after > > the patch series has been applied: > > > > POWER_SUPPLY_VOLTAGE_MIN_DESIGN=10800000 > > POWER_SUPPLY_VOLTAGE_MAX_DESIGN=10800000 > > Is that correct, BTW? sounds like these should not be equal... (Some) GE batteries have weird values stored in the SBS chip. For example manufacturer and model name are swapped: POWER_SUPPLY_MANUFACTURER=UR18650A POWER_SUPPLY_MODEL_NAME=GEHC I carefully checked manufacturer/model name when writing these patches some time ago and came to the conclusion that the batteries do report it the wrong way around. I will have a look for the design voltages (which are not modified by this patchset), but I expect this to be another GE specific thing. -- Sebastian
Attachment:
signature.asc
Description: PGP signature
