Quoting Sivaprakash Murugesan (2020-06-01 05:41:15) > On 5/28/2020 7:29 AM, Stephen Boyd wrote: > > Quoting Sivaprakash Murugesan (2020-05-27 05:24:51) > >> diff --git a/drivers/clk/qcom/apss-ipq6018.c b/drivers/clk/qcom/apss-ipq6018.c > >> new file mode 100644 > >> index 0000000..004f7e1 > >> --- /dev/null > >> +++ b/drivers/clk/qcom/apss-ipq6018.c > >> @@ -0,0 +1,106 @@ > >> + P_XO, > >> + P_APSS_PLL_EARLY, > >> +}; > >> + > >> +static const struct clk_parent_data parents_apcs_alias0_clk_src[] = { > >> + { .fw_name = "xo" }, > >> + { .fw_name = "pll" }, > > This pll clk is not described in the binding. Please add it there. > > Sorry I did not get this, this PLL is not directly defined in this > driver and it comes > > from dts. do you still want to describe it in binding? > Yes, there should be a clock-names property for "pll" and a clocks property in the binding document. I didn't see that.