On 05/02/2020 12:25 AM, Rob Herring wrote: >> Renesas Reduced Pin Count Interface (RPC-IF) allows a SPI flash or >> HyperFlash connected to the SoC to be accessed via the external address >> space read mode or the manual mode. >> >> Document the device tree bindings for the Renesas RPC-IF found in the R-Car >> gen3 SoCs. >> >> Based on the original patch by Mason Yang <masonccyang@xxxxxxxxxxx>. >> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> >> [...] >> Index: linux/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml >> =================================================================== >> --- /dev/null >> +++ linux/Documentation/devicetree/bindings/memory-controllers/renesas,rpc-if.yaml >> @@ -0,0 +1,88 @@ [...] >> +patternProperties: >> + "^.*@[0-9a-f]+$": > > ^flash@... if you're that restrictive. > >> + type: object >> + properties: >> + compatible: >> + oneOf: >> + - const: cfi-flash >> + - const: jedec,spi-nor > > enum is better than oneOf+const. - enum: - cfi-flash - jedec,spi-nor causes the build error you encountered while trying to merge the last time. What was I doing wrong? [...] MBR, Sergei