On Sat, May 24, 2014 at 12:06:30PM +0200, Hans de Goede wrote: > On 05/23/2014 06:27 PM, Mark Brown wrote: > > On Fri, May 23, 2014 at 01:50:40PM +0200, Hans de Goede wrote: > >> On 05/23/2014 01:22 PM, Mark Brown wrote: > >> The compatible is not a Linux specific thing, it is a marking saying > >> that something needs to take care of enabling the clks (and whatever > >> else we will make part of the binding for this compatible), before > >> scanning the mmc bus. > > We could just say that the mere presence of a child node with the right > > properties is sufficient to trigger the bus to do the startup? > Yes, except that most involved property names are standardized, ie clocks, > and we want to be able to opt out of the KISS mmc core code for > (future) complex power on sequences. This is why I'm suggesting keying off the specific compatible strings for drivers that want to opt out of the helpers rather than having a compatible string to enable the helpers (which may depend on the particular Linux version if the feature sets of drivers change for example). > > If the device is sufficiently complicated to need a special power up > > sequence I'd expect we'd be able to have a compatible string which would > > provide enough information for us to figure things out. > Hmm, so what you're suggesting is indeed more of an opt out then my initial > opt-in to KISS powerup idea. So to be clear what you're suggesting is: > mmc core walks host mmc-child nodes. Loads drivers based on compatibles > there. The checks a flag field in the driver to see if the driver wants to > opt-out of the KISS powerup code. The problem with this is that it won't Yes. > work reliable with modules, think the mmc probe being done from the ramdisk, > and the driver in question only being available from the rootfs. I really Why is that a problem - if we have no driver for the device there is no point in powering it up in the first place is there? > believe that using opt-in with a compatible such as simple-sdio-powerup > is by far the safest thing to do, and as an added advantage we don't need > to worry about how to deal with the future complex power on cases at all, > we leave all the room in the world for various future scenarios. since as > soon as the simple-sdio-powerup compatible is not there the mmc core will > behave as it does today. Please remember that the DT is *supposed* to be an ABI - systems are supposed to be able to ship with a fixed DT and have it work with random operating systems they have no knowledge of (and may not even exist at the time the DT is being created). This means we can't rely on removing a compatible string later on. > >> Hmm, good point in that case actually having these things in the > >> child node makes most sense, because then the driver can find them > >> their. Note that the mmc core enabling things does not mean that > >> the driver cannot later disable them if needed. > > Right, that's good idea for solving the problem - the child device can > > either share the reference with the bus or have some way of getting at > > the object the bus requested depending on what's sensible. Only > I don't think there is a need to share references, ie for clks multiple drivers > can hold a reference and they can be enabled / disabled multiple times, only > when the last enable is countered by a disable the clock will really be disabled, > iow this should all just work. Anyways these are all implementation details > lets focus on the bindings bit first. The reference I'm referring to here is the enable - a driver should not normally disable something it didn't enable itself.
Attachment:
signature.asc
Description: Digital signature
