Hi Rob, On 29/05/20 3:44 am, Rob Herring wrote: > On Wed, May 20, 2020 at 06:14:46PM +0530, Lokesh Vutla wrote: >> Drop the firmware related dt-bindings and use the hardware specified >> interrupt numbers within Interrupt Router. This ensures interrupt router >> DT node need not assume any interrupt parent type. > > I didn't like this binding to begin with, but now you're breaking > compatibility. Yes, I do agree that this change is breaking backward compatibility. But IMHO, this does cleanup of firmware specific properties from DT. Since this is not deployed out yet in the wild market, I took the leverage of breaking backward compatibility. Before accepting these changes from firmware team, I did discuss[0] with Marc on this topic. > >> Signed-off-by: Lokesh Vutla <lokeshvutla@xxxxxx> >> --- >> .../interrupt-controller/ti,sci-intr.txt | 31 ++++++++++--------- >> 1 file changed, 16 insertions(+), 15 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt >> index 1a8718f8855d..8b56b2de1c73 100644 >> --- a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt >> +++ b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt >> @@ -44,15 +44,17 @@ Required Properties: >> 4: If intr supports level triggered interrupts. >> - interrupt-controller: Identifies the node as an interrupt controller >> - #interrupt-cells: Specifies the number of cells needed to encode an >> - interrupt source. The value should be 2. >> - First cell should contain the TISCI device ID of source >> - Second cell should contain the interrupt source offset >> - within the device. >> + interrupt source. The value should be 1. >> + First cell should contain interrupt router input number >> + as specified by hardware. >> - ti,sci: Phandle to TI-SCI compatible System controller node. >> -- ti,sci-dst-id: TISCI device ID of the destination IRQ controller. >> -- ti,sci-rm-range-girq: Array of TISCI subtype ids representing the host irqs >> - assigned to this interrupt router. Each subtype id >> - corresponds to a range of host irqs. >> +- ti,sci-dev-id: TISCI device id of interrupt controller. >> +- ti,interrupt-ranges: Set of triplets containing ranges that convert >> + the INTR output interrupt numbers to parent's >> + interrupt number. Each triplet has following entries: >> + - First entry specifies the base for intr output irq >> + - Second entry specifies the base for parent irqs >> + - Third entry specifies the limit > > Humm, sounds like what interrupt-map does. Okay, Ill look at it. [0] https://lore.kernel.org/linux-arm-kernel/2331f04eacee3b06cc152fc609225233@xxxxxxxxxxx/ Thanks and regards, Lokesh
