On Thu, May 28, 2020 at 11:15 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Thu, 28 May 2020 19:37:55 +0900, Steve Lee wrote: > > Add DT binding of max98390 amplifier driver. > > > > Signed-off-by: Steve Lee <steves.lee@xxxxxxxxxxxxxxxxxxx> > > --- > > Changed since V5: > > * Change txt to yaml and fix up the examples. > > Changed since V4: > > * No changes. > > Changed since V3: > > * No changes. > > Changed since V2: > > * No changes. > > Changed since V1: > > * Modified sample text in example > > > > .../bindings/sound/maxim,max98390.yaml | 39 +++++++++++++++++++ > > 1 file changed, 39 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/maxim,max98390.yaml > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > Documentation/devicetree/bindings/sound/maxim,max98390.yaml: mapping values are not allowed in this context > in "<unicode string>", line 22, column 97 > Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/sound/maxim,max98390.example.dts' failed > make[1]: *** [Documentation/devicetree/bindings/sound/maxim,max98390.example.dts] Error 1 > make[1]: *** Waiting for unfinished jobs.... > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/maxim,max98390.yaml: ignoring, error parsing file > warning: no schema found in file: ./Documentation/devicetree/bindings/sound/maxim,max98390.yaml > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/maxim,max98390.yaml: ignoring, error parsing file > warning: no schema found in file: ./Documentation/devicetree/bindings/sound/maxim,max98390.yaml > Makefile:1300: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > > See https://patchwork.ozlabs.org/patch/1299651 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > Please check and re-submit. > Thanks for feedback. I re-submit with after dt binding check again.