Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote on Thu, 28 May 2020 17:56:56 +0200: > On Thu, 28 May 2020 13:31:13 +0200 > Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote: > > > +/** > > + * nanddev_get_flash_node() - Get the device node attached to a NAND device > > + * @nand: NAND device > > + * > > + * Return: the device node linked to @nand. > > + */ > > +static inline struct device_node *nanddev_get_flash_node(struct nand_device *nand) > > +{ > > + return mtd_get_of_node(nanddev_to_mtd(nand)); > > +} > > + > > Can we name that one nanddev_get_of_node(). We'll probably want to > expose fwnode at some point, and get_flash_node() is a bit too generic > IMO. I just spot that there is a nanddev_get_of_node() function already, which does exactly the same as nanddev_get_flash_node(), so I just dropped it.