On Thu, 28 May 2020 13:31:13 +0200 Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote: > diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h > index ce936ffb9f42..1cc6d71c2b45 100644 > --- a/include/linux/mtd/nand.h > +++ b/include/linux/mtd/nand.h > @@ -127,6 +127,10 @@ struct nand_page_io_req { > int mode; > }; > > +extern const struct mtd_ooblayout_ops nand_ooblayout_sp_ops; > +extern const struct mtd_ooblayout_ops nand_ooblayout_lp_ops; > +extern const struct mtd_ooblayout_ops nand_ooblayout_lp_hamming_ops; While we move that to the generic NAND layer, can we hide that behind helpers so we don't have the objects directly exposed? const struct mtd_ooblayout_ops *nand_get_small_page_layout(); const struct mtd_ooblayout_ops *nand_get_large_page_layout(); const struct mtd_ooblayout_ops *nand_get_large_page_hamming_layout();