On Thu, May 28, 2020 at 02:44:32PM +0200, Arnd Bergmann wrote: > On Thu, May 28, 2020 at 2:27 PM Serge Semin > <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> wrote: > > > > On Thu, May 28, 2020 at 02:14:58PM +0200, Arnd Bergmann wrote: > > > On Thu, May 28, 2020 at 12:01 AM Andy Shevchenko > > > <andy.shevchenko@xxxxxxxxx> wrote: > > > > On Tuesday, May 26, 2020, Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> wrote: > > > >> > > > >> AXI3-bus is the main communication bus connecting all high-speed > > > >> peripheral IP-cores with RAM controller and MIPS P5600 cores on Baikal-T1 > > > >> SoC. Bus traffic arbitration is done by means of DW AMBA 3 AXI > > > >> Interconnect (so called AXI Main Interconnect) routing IO requests from > > > >> one SoC block to another. This driver provides a way to detect any bus > > > >> protocol errors and device not responding situations by means of an > > > >> embedded on top of the interconnect errors handler block (EHB). AXI > > > >> Interconnect QoS arbitration tuning is currently unsupported. > > > >> The bus doesn't provide a way to detect the interconnected devices, > > > >> so they are supposed to be statically defined like by means of the > > > >> simple-bus sub-nodes. > > > > > > > > > > > > > > > > Few comments in case if you need a new version. Main point is about sysfs_streq(). > > > > > > I've applied the patch now and folded in fixes for the build warnings and > > > errors pointed out by the test robot, but I did not include the changes you > > > suggested. > > > > Are you saying that the build-errors and warnings have already been fixed by > > you, right? If so could you please give me a link to the repo with those > > commits, so I'd work with the up-to-date code? > > I've pushed it to https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/, > > I made a local "baikal/drivers" branch with just your patches, updated > to address the build reports. This is merged into the "arm/drivers" > branch that contains all driver specific changes across all SoCs and > this is what I'll send to Linus next week. > > There is also the "for-next" branch that contains all arm/* branches, > and this is what gets pulled into linux-next, so your patches will show > up there tomorrow as well. I see. Thanks for explanation. I've monitored the soc/soc.git a few minutes ago, but the gitolite web-interface showed me that the last update was made 9 hours ago. So I thought you could be using some another repo. Now I see the fresh updates and the drivers being merges. I'll address the Andy's comments and send a follow-up patches with fixes shortly today. BTW I don't see the next commit: [PATCH v3 3/6] dt-bindings: memory: Add Baikal-T1 L2-cache Control Block binding in the baikal/drivers, so the l2-ctl binding hasn't been merged into the arm/drivers and for-next branches. You must have missed that patch. Could you please make sure it's also merged in? Thanks -Sergey > > You can normally check the status of any submission to soc@xxxxxxxxxx > at https://patchwork.kernel.org/project/linux-soc/list/, but it seems that > has not picked up the status yet, and I'll have to update it manually. > > Arnd
