Hi Stephen, On 27/5/2020 10:10 am, Stephen Boyd wrote: > Quoting Rahul Tanwar (2020-04-16 22:54:47) >> diff --git a/drivers/clk/x86/clk-cgu.c b/drivers/clk/x86/clk-cgu.c >> new file mode 100644 >> index 000000000000..802a7fa88535 >> --- /dev/null >> +++ b/drivers/clk/x86/clk-cgu.c >> @@ -0,0 +1,636 @@ > [...] >> + ctx->membase = devm_platform_ioremap_resource(pdev, 0); >> + if (IS_ERR(ctx->membase)) >> + return PTR_ERR(ctx->membase); >> + >> + ctx->np = np; >> + ctx->dev = dev; >> + spin_lock_init(&ctx->lock); >> + >> + ret = lgm_clk_register_plls(ctx, lgm_pll_clks, >> + ARRAY_SIZE(lgm_pll_clks)); >> + if (ret) >> + return ret; >> + >> + ret = lgm_clk_register_branches(ctx, lgm_branch_clks, >> + ARRAY_SIZE(lgm_branch_clks)); >> + if (ret) >> + return ret; >> + >> + ret = lgm_clk_register_ddiv(ctx, lgm_ddiv_clks, >> + ARRAY_SIZE(lgm_ddiv_clks)); >> + if (ret) >> + return ret; >> + >> + ret = devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get, >> + &ctx->clk_data); >> + if (ret) >> + return ret; > Are any of the clks unregistered on failure? It looks like devm_ isn't > used for registration so nothing can be undone? Please fix this in a > future patch. Thanks a lot for accepting the patch series. I went through all of your comments and i agree with all of them. Will fix it & address other review concerns in a future patch once 5.8 is released. Regards, Rahul
