On Sun, May 17, 2020 at 09:52:38PM +0800, vineetha.g.jaya.kumaran@xxxxxxxxx wrote: > From: "Lai, Poey Seng" <poey.seng.lai@xxxxxxxxx> > > In Keem Bay, the number of repetitions for the period/waveform > can be configured from userspace. This requires addition of a sysfs > attribute to get/set the repetition count. Setting this value to 0 > will result in continuous repetition of the waveform until the > channel is disabled or reconfigured. There is nothing specific for Keem Bay in this patch, the only special thing here is that this driver is the first implementor. IMHO all drivers that don't support count should be changed to fail if a count > 0 is passed and introducing support in the sysfs interface should be a separate change. Having said that I'm not convinced this is a good idea given that only very few driver can support this interface. Also this needs documentation, e.g. what is expected from .get_state(). You should also motivate what this functionality is used for in the commit log and I'd prefer to see an in-tree user (apart from sysfs which I don't count as such). Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
