Hello, This provides a patch, but it doesn't look like the right one. It looks like the if test should be testing opp_table, julia On Fri, 22 May 2020, kbuild test robot wrote: > From: kbuild test robot <lkp@xxxxxxxxx> > > drivers/devfreq/governor_passive.c:336:7-13: inconsistent IS_ERR and PTR_ERR on line 337. > > PTR_ERR should access the value just tested by IS_ERR > > Semantic patch information: > There can be false positives in the patch case, where it is the call to > IS_ERR that is wrong. > > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci > > CC: Saravana Kannan <skannan@xxxxxxxxxxxxxx> > Signed-off-by: kbuild test robot <lkp@xxxxxxxxx> > --- > > url: https://github.com/0day-ci/linux/commits/Andrew-sh-Cheng/Add-cpufreq-and-cci-devfreq-for-mt8183-and-SVS-support/20200520-222709 > base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next > :::::: branch date: 26 hours ago > :::::: commit date: 26 hours ago > > Please take the patch only if it's a positive warning. Thanks! > > governor_passive.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/devfreq/governor_passive.c > +++ b/drivers/devfreq/governor_passive.c > @@ -334,7 +334,7 @@ static int cpufreq_passive_register(stru > > opp_table = dev_pm_opp_get_opp_table(cpu_dev); > if (IS_ERR(devfreq->opp_table)) { > - ret = PTR_ERR(opp_table); > + ret = PTR_ERR(devfreq->opp_table); > goto out; > } > >
