On Thu, May 21, 2020 at 04:51:43PM +0100, Mark Brown wrote: > On Thu, May 21, 2020 at 03:12:28PM +0300, Serge Semin wrote: > > > Well, for me both solutions are equal except mine consumes less stack memory. > > The only reason why your solution might be better is that if DW DMA driver or > > the DMA engine subsystem changed the dw_dma_slave structure instance passed to > > the dma_request_channel() method, which non of them do. So I'll leave this for > > Mark to decide. Mark, could you give us your final word about this? > > Honestly I'm struggling to care either way. I guess saving a bit of > stack is potentially useful. Settled then. Let's leave the patch as is. I suppose we've finally finished a review except a question Feng asked to the patch: [PATCH v3 01/16] spi: dw: Add Tx/Rx finish wait methods to the MID DMA If you are ok with my responses, then the patchset is ready for you further actions. -Sergey
