On Wed, May 20, 2020 at 04:31:55PM +0800, fugang.duan@xxxxxxx wrote: > From: Fugang Duan <fugang.duan@xxxxxxx> > > Update the gpr property to define gpr register offset and > bit in DT. > > Signed-off-by: Fugang Duan <fugang.duan@xxxxxxx> > --- > arch/arm/boot/dts/imx6qdl.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi > index 98da446..a4a68b7 100644 > --- a/arch/arm/boot/dts/imx6qdl.dtsi > +++ b/arch/arm/boot/dts/imx6qdl.dtsi > @@ -1045,7 +1045,7 @@ > <&clks IMX6QDL_CLK_ENET>, > <&clks IMX6QDL_CLK_ENET_REF>; > clock-names = "ipg", "ahb", "ptp"; > - gpr = <&gpr>; > + gpr = <&gpr 0x34 27>; > status = "disabled"; > }; Hi Andy This is the same values as hard coded, so no change here. The next patch does not use grp at all. So it is unclear to me if you actually make use of what you just added. I don't see anywhere gpr = <&gpr 0x42 24>; which is the whole point of this change, being able to specify different values. Andrew