On Tue, May 19, 2020 at 01:08:15PM +0300, Andy Shevchenko wrote: > On Tue, May 19, 2020 at 11:48:35AM +0200, Jonathan Albrieux wrote: > > On Tue, May 19, 2020 at 12:22:12PM +0300, Andy Shevchenko wrote: > > > On Tue, May 19, 2020 at 08:57:40AM +0200, Jonathan Albrieux wrote: > > ... > > > > I dunno if it's your first submission to Linux kernel project or other OSS, > > > but here you missed a changelog. Rule of thumb is to provide a summary of > > > the changes done in the history of the evolution of a patch series. > > > > > > > Oh thank you and sorry for not having included it. > > > > Does the changelog needs to be added to all patch files or just on the ones > > subject of the changes? > > Up to you and maintainer of the corresponding subsystem. > > My common sense tells me that > 1) if there is a cover letter, just put a joined changelog there > 2) otherwise, put changelog in each patch. > > I saw in practice all possible variants, i.e. > a) cover letter w/o changelog + changelog per patch; > b) cover letter w/ changelog + changelog per patch; > c) cover letter w/ changelog. > > I think any of it is fine in general. > > -- > With Best Regards, > Andy Shevchenko > > Thank you for the tips, will work on it! Best regards, Jonathan Albrieux
