On Sun, May 10, 2020 at 12:50:09PM +0300, Serge Semin wrote: > Add the "baikal,bt1-sys-i2c" compatible string to the DW I2C binding and > make sure the reg property isn't required in this case because the > controller is embedded into the Baikal-T1 System Controller. The rest of > the DW APB I2C properties are compatible and can be freely used to describe > the Baikal-T1 I2C controller dts-node. Is there not a sub-range of the system controller with the I2C registers? I'd assume there is, so you can still have 'reg' even if Linux doesn't use it (currently). > > Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> > Cc: Alexey Malahov <Alexey.Malahov@xxxxxxxxxxxxxxxxxxxx> > Cc: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> > Cc: Paul Burton <paulburton@xxxxxxxxxx> > Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx> > Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> > Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx> > Cc: Frank Rowand <frowand.list@xxxxxxxxx> > Cc: linux-mips@xxxxxxxxxxxxxxx > > --- > > Rob, I had to remove your acked-by tag because of the changes introduced > in v2 of the patch. > > Changelog v2: > - Make the reg property being optional if it's Baikal-T1 System I2C DT > node. > --- > .../devicetree/bindings/i2c/snps,designware-i2c.yaml | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml > index 8d4e5fccbd1c..579964098eb9 100644 > --- a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml > @@ -21,6 +21,15 @@ allOf: > properties: > reg: > maxItems: 1 > + - if: > + properties: > + compatible: > + not: > + contains: > + const: baikal,bt1-sys-i2c > + then: > + required: > + - reg > > properties: > compatible: > @@ -31,6 +40,8 @@ properties: > items: > - const: mscc,ocelot-i2c > - const: snps,designware-i2c > + - description: Baikal-T1 SoC System I2C controller > + const: baikal,bt1-sys-i2c > > reg: > minItems: 1 > @@ -98,7 +109,6 @@ unevaluatedProperties: false > > required: > - compatible > - - reg > - "#address-cells" > - "#size-cells" > - interrupts > -- > 2.25.1 >
