On 0518, Amit Tomer wrote: > Hi, > > > I recommend reading the DT spec, chapter 2.3.1 "compatible": > > https://github.com/devicetree-org/devicetree-specification/releases/download/v0.3/devicetree-specification-v0.3.pdf > > My point is more about, DT validation is not happy about this situation. > For instance when I run dt-validate, do see following: > > /home/amit/work/kernel_work/linux/arch/arm64/boot/dts/actions/s700-cubieboard7.dt.yaml: > mmc@e0210000: compatible: Additional items are not allowed > ('actions,s700-mmc' was unexpected) > > and I am not sure if this is because DT and driver has different > number of compatible strings. > Yeah, the DT YAML validation tool doesn't allow this. And there were patches removing the additional compatible from DTS. I don't know if the DT fallback is discouraged or not. Anyway, is enough investigation done to justify that we need SoC specific tweaks in the driver? I think I did look into the downstream code for s700/s500 while upstreaming this driver and convinced myself that the same driver could be reused without modifications. Thanks, Mani > Thanks > Amit
